Correct exception logging #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcekan
commented
Mar 9, 2021
| @@ -40,10 +40,10 @@ public void run() { | |||
| asyncAPIDao.updateAsyncAPIResult(queryResultObj, queryObj.getId(), queryObj.getClass()); | |||
|
|
|||
| } catch (InterruptedException e) { | |||
| log.error("InterruptedException: {}", e); | |||
| log.error("InterruptedException: {}", e.toString()); | |||
There was a problem hiding this comment.
If the stack trace is intended, we need to instead remove the {} from the formatting
log.error("InterruptedException", e);
There was a problem hiding this comment.
stacktrace was not intended.
There was a problem hiding this comment.
What is the purpose of:
Thread.currentThread().interrupt();
?
moizarafat
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always re-throw or re-interrupt when catching the
InterruptedException.When the final argument in a slf4j log message is a throwable, it generates a stack trace and is not one of the formatting arguments.
It appears the code had intended to display only the .toString based on the unused
{}Motivation and Context
Incorrect logging
How Has This Been Tested?
Unit testing
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.