Refactor legacy hooks #1896
Merged
Refactor legacy hooks #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcekan
force-pushed
the
commit-checks
branch
3 times, most recently
from
1187a75
to
115aba7
Compare
aklish
requested changes
Mar 10, 2021
elide-core/src/main/java/com/yahoo/elide/core/security/checks/Check.java
Outdated
Show resolved
Hide resolved
elide-core/src/test/java/com/yahoo/elide/core/lifecycle/LegacyTestModel.java
Show resolved
Hide resolved
wcekan
force-pushed
the
commit-checks
branch
2 times, most recently
from
734a8ac
to
20132db
Compare
aklish
requested changes
Mar 11, 2021
| * | ||
| * @return true to run at commit | ||
| */ | ||
| public boolean runAtCommit() { |
There was a problem hiding this comment.
Can we move this into Check as default method?
Then, in FilterExpressionCheck and UserCheck, override it to always return false and make the method final (so it cannot be overwritten).
aklish
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FilterTranslatorandOperatorrunAtCommitmethod in Check.Motivation and Context
Fixing issues found in migrating from 4.x to 5.x
How Has This Been Tested?
Unit testing. Local testing with own Elide project.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.