httpclient 4.5.13 #2074
Merged
httpclient 4.5.13 #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklish
reviewed
May 6, 2021
| @@ -104,6 +104,12 @@ | |||
| </exclusions> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>org.apache.httpcomponents</groupId> | |||
There was a problem hiding this comment.
changed scope to runtime to match the dependencies of calcite
There was a problem hiding this comment.
We don't use calcite to make HTTP connections though. Is there any reason we can't simply exclude it?
There was a problem hiding this comment.
No. If we mention calcite without any mention of httpclient the downstream will pull in the calcite old version of httpclient. They have the option to exclude it, but sadly maven does not let us exclude on their behalf.
There was a problem hiding this comment.
Can we add a comment:
Avoid CVE-2020-13956
aklish
approved these changes
May 6, 2021
aklish
requested changes
May 6, 2021
| @@ -104,6 +104,12 @@ | |||
| </exclusions> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>org.apache.httpcomponents</groupId> | |||
There was a problem hiding this comment.
Can we add a comment:
Avoid CVE-2020-13956
aklish
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid CVE-2020-13956
Motivation and Context
Security
How Has This Been Tested?
Unit testing
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.