Create Elide Bill Of Materials (7.x) #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `version.logback` from 1.2.11 to 1.4.5. Updates `logback-classic` from 1.2.11 to 1.4.5 - [Release notes](https://github.com/qos-ch/logback/releases) - [Commits](qos-ch/logback@v_1.2.11...v_1.4.5) Updates `logback-core` from 1.2.11 to 1.4.5 - [Release notes](https://github.com/qos-ch/logback/releases) - [Commits](qos-ch/logback@v_1.2.11...v_1.4.5) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: ch.qos.logback:logback-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
wcekan
commented
Feb 11, 2023
pom.xml
Outdated
| @@ -86,7 +87,7 @@ | |||
| <!-- dependency versions --> | |||
| <version.antlr4>4.10.1</version.antlr4> | |||
| <version.jetty>11.0.13</version.jetty> | |||
| <version.logback>1.2.11</version.logback> | |||
| <version.logback>1.4.5</version.logback> | |||
There was a problem hiding this comment.
Fixes error
07:59:31 SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
07:59:31 SLF4J: Ignoring binding found at [jar:file:/root/.m2/repository/ch/qos/logback/logback-classic/1.2.11/logback-classic-1.2.11.jar!/org/slf4j/impl/StaticLoggerBinder.class]
wcekan
commented
Feb 11, 2023
| <version.restassured>5.3.0</version.restassured> | ||
| <version.jackson>2.14.1</version.jackson> | ||
| <version.jackson.databind>2.14.1</version.jackson.databind> |
There was a problem hiding this comment.
Jackson should define the correct component versions, not Elide.
i.e. https://mvnrepository.com/artifact/com.fasterxml.jackson/jackson-bom/2.13.4.20221013
wcekan
commented
Feb 11, 2023
| <version.junit>5.9.1</version.junit> | ||
| <version.junit.platform>1.9.1</version.junit.platform> |
There was a problem hiding this comment.
JUnit will define the correct junit.platform component versions
wcekan
commented
Feb 11, 2023
| @@ -41,7 +41,6 @@ | |||
| <properties> | |||
| <parent.pom.dir>${project.basedir}/../..</parent.pom.dir> | |||
| <spring.boot.version>3.0.1</spring.boot.version> | |||
| <groovy.version>3.0.13</groovy.version> | |||
There was a problem hiding this comment.
Unused since spring 2.7.0. rest-assured now uses org.apache.groovy not org.codehaus.groovy
[INFO] com.yahoo.elide:elide-spring-boot-autoconfigure:jar:7.0.0-RC7-SNAPSHOT
[INFO] +- io.rest-assured:rest-assured:jar:5.2.1:test
[INFO] | +- org.apache.groovy:groovy:jar:4.0.6:test (version managed from 4.0.1)
[INFO] | +- org.apache.groovy:groovy-xml:jar:4.0.6:test (version managed from 4.0.1)
[INFO] | | \- (org.apache.groovy:groovy:jar:4.0.6:test - version managed from 4.0.1; omitted for duplicate)
aklish
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create the Elide Bill Of Materials.
See Apache bill of materials (BOM) files
Update build to use dependency Bill Of Materials.
Motivation and Context
See Spring doc
Jackson BOM
Gradle bom import
Synchronizing Elide jars will only require
How Has This Been Tested?
Built locally and used elide-bom with a local project.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.