loadObject should return unique result #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklish
reviewed
Apr 11, 2019
| return it.next(); | ||
| Object obj = it.next(); | ||
| if (!it.hasNext()) { | ||
| return obj; |
There was a problem hiding this comment.
Maybe throw an exception instead of returning null.
There was a problem hiding this comment.
The contract is for loadObject to return null if no object is loaded. But perhaps we can throw an exception when too many are returned.
aklish
requested changes
Apr 12, 2019
| return it.next(); | ||
| Object obj = it.next(); | ||
| if (!it.hasNext()) { | ||
| return obj; |
There was a problem hiding this comment.
Maybe throw an exception instead of returning null.
aklish
force-pushed
the
defaultDataStore
branch
from
815cbec
to
483d9e8
Compare
aklish
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default datastore
loadObjectfails to filter to a single result, do not return any.Currently the first element of the collection would erroneously be returned.