fix(fslib): match node behaviour in fs.read
on Windows
#3049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When calling
fs.read(0, ...)
on Windows after stdin is closed Node calls the callback with anEOF
error but still providesbytesRead
andbuffer
, with PnP only the error is provided.Ref nodejs/node#35997
Fixes #3045
How did you fix it?
Match the node behaviour and provide both
bytesRead
andbuffer
onEOF
errors on WindowsChecklist