Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows paths #33

Merged
merged 33 commits into from
Mar 26, 2019
Merged

Support Windows paths #33

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
cf63763
Base work for portable path
Embraser01 Mar 19, 2019
3ea7ac5
Add conversion where needed (still missing some!)
Embraser01 Mar 20, 2019
ca12605
Got it to work on Windows!
Embraser01 Mar 20, 2019
9d9af0e
Convert to portable path when calling 'yarn <path> install'
Embraser01 Mar 20, 2019
e7f88b3
Update config.ts
arcanis Mar 20, 2019
5afdbfe
Use posix where possible
Embraser01 Mar 20, 2019
9d8c602
Use xfs in json-proxy instead of native fs
Embraser01 Mar 20, 2019
9f7baa7
Fix berry json proxy dependencies
Embraser01 Mar 20, 2019
293d4c4
Handle more special cases (globby, pnp), activate Windows Pipeline
Embraser01 Mar 22, 2019
08434df
Fix PATH env variable when spawn process
Embraser01 Mar 22, 2019
91da8f7
Fix azure yaml
Embraser01 Mar 22, 2019
9e2c73a
Fixes plugin loading
arcanis Mar 22, 2019
a84f28a
Updates the checked-in build
Mar 22, 2019
fd90c88
Fixes yarn-path execution
Mar 22, 2019
15e5a14
Debug: Adds logging to findZip
Mar 22, 2019
1006c08
Revert "Debug: Adds logging to findZip"
Mar 22, 2019
06f4cad
Enforces symlinks on Windows
Mar 22, 2019
935ef94
Fixes the cmd scripts
Mar 22, 2019
47996f1
Adds a retry for EBUSY and ENOTEMPTY
Mar 22, 2019
e5cc92a
Fixes process spawning on win32
arcanis Mar 23, 2019
bff06d3
More portable path, prevent translating to portable path if already one
Embraser01 Mar 24, 2019
c03bdb4
Some cleanup for PnP hook on Windows
Embraser01 Mar 25, 2019
73b0472
Merge branch 'master' into windows-portable-path
Embraser01 Mar 25, 2019
3ea0c94
Use only portable path in Native resolution
Embraser01 Mar 25, 2019
a25e7fd
Moves the portable path conversion in dedicated wrappers
Mar 25, 2019
9b58424
Makes fakeFs a parameter to instantiate a PnP API
Mar 25, 2019
7c49825
Updates the PnP hook
Mar 25, 2019
4633d4f
Fixes accidental infinite loop
Mar 25, 2019
b9d8553
Updates the checked-in PnP hook
Mar 25, 2019
22edde3
Fixes how the PnP linker interacts with the PnP API on Windows
Mar 25, 2019
2891c1a
Implements a fs layer to convert paths before they reach zipopenfs
Mar 25, 2019
010898a
Adds a few extra conversions
arcanis Mar 25, 2019
a9bf0fe
Updates the checked-in build
Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes plugin loading
  • Loading branch information
@arcanis @Embraser01
arcanis authored and Embraser01 committed Mar 24, 2019
commit 9e2c73af3f56fab0401101d3a5901ce2079ed66d
5 changes: 3 additions & 2 deletions packages/berry-core/sources/Configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,9 @@ export class Configuration {
if (!Array.isArray(data.plugins))
continue;

for (const pluginPath of data.plugins) {
const {factory, name} = nodeUtils.dynamicRequire(NodeFS.fromPortablePath(posix.resolve(cwd, pluginPath)));
for (const userProvidedPath of data.plugins) {
const pluginPath = posix.resolve(cwd, NodeFS.toPortablePath(userProvidedPath));
const {factory, name} = nodeUtils.dynamicRequire(NodeFS.fromPortablePath(pluginPath));

// Prevent plugin redefinition so that the ones declared deeper in the
// filesystem always have precedence over the ones below.
Expand Down