Fix auspice radial and unrooted views #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses nextstrain/auspice#1756 from the matUtils side by providing a bogus divergence value. Resulting file was tested on auspice.us and it now correctly goes into radial view. Unrooted view also loads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses nextstrain/auspice#1756 from the matUtils side by providing a (bogus) divergence value when converting to JSON. This makes the resulting JSON align closer to the schema that Auspice expects, and this enables radial and unrooted view to work properly.
Thanks to @jameshadfield for pinpointing exactly what was missing from the matUtils JSON, and @kvargha for finding the very silly Dockerfile issue that was preventing me from testing my changes properly!