Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official gocode is not supported anymore #1097

Closed
ChoppinBlockParty opened this issue Sep 3, 2018 · 3 comments · Fixed by #1098
Closed

Official gocode is not supported anymore #1097

ChoppinBlockParty opened this issue Sep 3, 2018 · 3 comments · Fixed by #1098

Comments

@ChoppinBlockParty
Copy link

As it is suggested in the main page nsf/gocode is not supported anymore. Any plans to switch to a new version mdempsy/gocode?
@micbou
Copy link
Collaborator

micbou commented Sep 3, 2018

Switching now to mdempsky's fork seems too premature. See mdempsky/gocode#46 (comment). I think we should wait for Gocode to be ticked off in the list in issue golang/go#24661.

@micbou micbou mentioned this issue Sep 3, 2018
Closed
@isaachier
Copy link

isaachier commented Sep 3, 2018 •
edited
Loading

mdempsky's fork is more up-to-date than nsf. Eventually, another fix will be added to support autocompletion from modules (modules being new in Go 1.11). From the original meeting notes (https://docs.google.com/document/d/1lB49VLzDrRd3wbXP1uLf-bHQyJRmH_Dc36JeEBlK-1Q):

Current state of the nation:
A number of tools “know” nothing about (and hence are broken from a user’s perspective) Go 1.11 module mode; e.g. goimports, gocode, guru etc
. . .
The work his team are doing to try and help with the migration of tools to go/packages; e.g. Rebecca Stambler will shortly (next couple of weeks) be working on fixing github.com/mdempsky/gocode (it was noted that github.com/nsf/gocode has been officially retired)

@micbou micbou mentioned this issue Sep 4, 2018
Merged
@micbou
Copy link
Collaborator

micbou commented Sep 4, 2018

Implemented by PR #1098.

zzbot added a commit that referenced this issue Sep 9, 2018
@zzbot
Auto merge of #1098 - micbou:update-gocode, r=micbou
10dc665 
[READY] Update Go completer

As discussed in issue #1097, switch the Gocode version to [mdempsky's fork](https://github.com/mdempsky/gocode). This requires moving the Gocode submodule to `third_party/go/src/github.com/mdempsky/gocode` and setting `GOPATH` to `third_party/go` when building Gocode. Do the same for Godef. This way, using [Manishearth's fork](https://github.com/Manishearth/godef) is not needed anymore.

The following changes to the Go completer are required with this new version of Gocode:
 - the `status` endpoint has been removed so the server is now assumed to be healthy if it's running;
 - the `null` response is returned when there are no completions.

Closes #1090.
Closes #1092.
Closes #1097.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1098)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[READY] Update Go completer micbou/ycmd
3 participants
@isaachier @micbou @ChoppinBlockParty