Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve heart beat animation #4

Merged

Conversation

iNorthIsle
Copy link
Collaborator

Summary

The repo is awesome, and the idea is COOL! But I have a little bit of OCD:

  • The Heart-Beat looks lazy and not energetic 🤣
  • The effect of text ( fade-in & fade-out ) exists some ghosts 👻

Change

Before After
before after

The gif loss of frame, U can check it in here

The animation style is optional & personal, it`s just a bit of advice or improvement.

Notice:

if you would like to have approval and merge the PR, U may pay attention to the data source and can help to test it, I can not trigger the Github action success through the input data with the correct format. so I modified this function, and it`s successful on the main branch, but I restore the modification in this PR, it should not break the CI.
image

@yihong0618
Copy link
Owner

Cool, I like your effect of beating.

@yihong0618 yihong0618 merged commit 0ba5983 into yihong0618:main Nov 16, 2021
@yihong0618
Copy link
Owner

yihong0618 commented Nov 16, 2021

Can you update the example to your new effect too?

@iNorthIsle
Copy link
Collaborator Author

Can you update the example to yours new effect too?
sure 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants