Merge PR cosmos#1191: LCD cleanup / add LCD gas field

* remove global variables from lcd
* added make race, fix lcd race condition
* cleanup
* Five-character changelog update

.gitignore

@@ -14,6 +14,7 @@ docs/_build
 # Data - ideally these don't exist
 examples/basecoin/app/data
 baseapp/data/*
+client/lcd/keys/*
 
 # Testing
 coverage.txt
@@ -26,4 +27,4 @@ profile.out
 vagrant
 
 # Graphviz
-dependency-graph.png
+dependency-graph.png

CHANGELOG.md

@@ -2,17 +2,19 @@
 
 BREAKING CHANGES
 * msg.GetSignBytes() now returns bech32-encoded addresses in all cases
+* [lcd] REST end-points now include gas
 
 FEATURES
 
 IMPROVEMENTS
 * export command now writes current validator set for Tendermint
 * [tests] Application module tests now use a mock application
 * [gaiacli] Fix error message when account isn't found when running gaiacli account
+* [lcd] refactored to eliminate use of global variables, and interdependent tests
 
 FIXES
 * [lcd] Switch to bech32 for addresses on all human readable inputs and outputs
-* fixed tx indexing/querying
+* [lcd] fixed tx indexing/querying
 * [cli] Added `--gas` flag to specify transaction gas limit
 
 ## 0.18.0

Makefile

@@ -92,6 +92,9 @@ test_cli:
 test_unit:
 	@go test $(PACKAGES_NOCLITEST)
 
+test_race:
+	@go test -race $(PACKAGES_NOCLITEST)
+
 test_cover:
 	@bash tests/test_cover.sh
 

client/keys/utils.go

@@ -21,6 +21,8 @@ const KeyDBName = "keys"
 // keybase is used to make GetKeyBase a singleton
 var keybase keys.Keybase
 
+// TODO make keybase take a database not load from the directory
+
 // initialize a keybase based on the configuration
 func GetKeyBase() (keys.Keybase, error) {
 	rootDir := viper.GetString(cli.HomeFlag)