Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate logged errors and warnings #293

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

rhertogh
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -

The same error or warning might be logged multiple times. This PR deduplicate them before writing them to their respective files.

@what-the-diff
Copy link

what-the-diff bot commented Jun 17, 2023

PR Summary

  • Code refactoring for better maintainability
    The code has been restructured to eliminate repeated logic, making it easier to maintain and understand.
  • Improved error and warning handling
    A new hash algorithm is used to ensure that the error and warning arrays are unique, preventing duplicate errors/warnings.
  • Alphabetical sorting of errors and warnings
    Errors and warnings are now sorted alphabetically by file name before being saved to their respective files: errors.txt and warnings.txt.

@rhertogh rhertogh marked this pull request as ready for review June 17, 2023 22:45
@samdark samdark added the type:bug Bug label Jun 20, 2023
@samdark samdark merged commit 1fbd391 into yiisoft:master Jun 20, 2023
4 checks passed
@samdark
Copy link
Member

samdark commented Jun 20, 2023

Thanks.

@samdark samdark added this to the 3.0.7 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants