Update checkbox/radio for configurable enclosed option. #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BaseHtml checkbox and radio implementation hard-codes a container to envelop the input when label is passed. For example: ```<div class="checkbox">``` or ```<div class="radio">```. This should be configurable. The current Pull Request allows the container enclosure to be optional by including an ```isEnclosed``` option.This is set to true by default. But it requires to be false for some scenarios. For example, the false option is very useful for generating inline checkbox lists or inline radio lists, where the enclosure is not required.
Updated ```isEnclosed``` to ```hasContainer``` - since there is an enclosed label somewhere (not to confuse). Also added unsetting of this variable in the ```options``` array after reading the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BaseHtml checkbox and radio implementation hard-codes a container to envelop the input when label is passed. For example:
<div class="checkbox">or<div class="radio">. This should be configurable. The current Pull Request allows the container enclosure to be optional by including anhasContaineroption.This is set to true by default so current implementation is not affected. But it also allows this to be set to false for some scenarios. For example, the false option is very useful for generating inline checkbox lists or inline radio lists, where the enclosure is not required.