Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 7渡し / 10捨て #52

Merged
merged 12 commits into from
Aug 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added dev/sounds_wave/transfer.wav
Binary file not shown.
25 changes: 11 additions & 14 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added public/sounds/transfer.mp3
Binary file not shown.
Binary file added public/sounds/transfer.webm
Binary file not shown.
8 changes: 8 additions & 0 deletions src/components/createRoomButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export default function CreateRoomButton(props: Props) {
const [kakumei, setKakumei] = React.useState<boolean>(true);
const [reverse, setReverse] = React.useState<boolean>(false);
const [skip, setSkip] = React.useState<SkipConfig>(SkipConfig.OFF);
const [transfer, setTransfer] = React.useState<boolean>(false);
const [exile, setExile] = React.useState<boolean>(false);

const handleCreateRoom = () => {
setIsCreating(true);
Expand All @@ -27,6 +29,8 @@ export default function CreateRoomButton(props: Props) {
kakumei: kakumei,
reverse: reverse,
skip: skip,
transfer: transfer,
exile: exile,
};
props.globalLogic.createGameRoom(rc, (success: boolean) => {
setIsCreating(false);
Expand Down Expand Up @@ -66,11 +70,15 @@ export default function CreateRoomButton(props: Props) {
kakumei={kakumei}
reverse={reverse}
skip={skip}
transfer={transfer}
exile={exile}
onYagiriChange={setYagiri}
onJBackChange={setJBack}
onKakumeiChange={setKakumei}
onReverseChange={setReverse}
onSkipChange={setSkip}
onTransferChange={setTransfer}
onExileChange={setExile}
/>
</Modal.Body>
<Modal.Footer>
Expand Down
14 changes: 8 additions & 6 deletions src/components/gameContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
DiscardPairListMessage,
encodeDiscardPairListMessage,
WaitReason,
YourTurnContext,
} from "dfg-messages";
import LeaveRoomButton from "./leaveRoomButton";

Expand All @@ -28,7 +29,7 @@ export default function GameContainer(props: Props) {
new GameStateDTO(new GameState())
);
const [ownerStatus, setOwnerStatus] = React.useState<boolean>(false);
const [isMyTurn, setIsMyTurn] = React.useState<boolean>(false);
const [isPassable, setIsPassable] = React.useState<boolean>(false);
const [cardList, setCardList] = React.useState<CardListMessage>(
encodeCardListMessage([])
);
Expand Down Expand Up @@ -70,14 +71,15 @@ export default function GameContainer(props: Props) {
updateLog(msg);
};

const handleMyTurn = (myTurn: boolean) => {
const handleMyTurn = (context:YourTurnContext, passable:boolean) => {
const myTurn = context !== YourTurnContext.INACTIVE;
if (myTurn) {
const msg = i18n.game_yourTurn();
const msg = i18n.game_yourTurn(context);
props.globalLogic.updateAutoRead(msg);
props.globalLogic.sound.enqueueEvent(SoundEvent.TURN);
setIsMyTurn(true);
setIsPassable(passable);
} else {
setIsMyTurn(false);
setIsPassable(false);
}
};

Expand Down Expand Up @@ -182,7 +184,7 @@ export default function GameContainer(props: Props) {
onCardSelectionChange={props.gameLogic.selectCard.bind(props.gameLogic)}
onDiscard={props.gameLogic.discard.bind(props.gameLogic)}
onPass={props.gameLogic.pass.bind(props.gameLogic)}
isPassable={isMyTurn}
isPassable={isPassable}
/>
<PlayingInfoPanel
globalLogic={props.globalLogic}
Expand Down
2 changes: 2 additions & 0 deletions src/components/roomList.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ function createRuleConfig(): RuleConfig {
kakumei: true,
reverse: false,
skip: SkipConfig.OFF,
transfer: false,
exile: false,
};
}

Expand Down
26 changes: 26 additions & 0 deletions src/components/roomSettingsModal.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,15 @@ test("renders settings with given parameters", () => {
const kakumei = true;
const reverse = false;
const skip = SkipConfig.OFF;
const transfer = false;
const exile = false;
const onYagiriChange = jest.fn((yagiri: boolean) => {});
const onJBackChange = jest.fn((jBack: boolean) => {});
const onKakumeiChange = jest.fn((kakumei: boolean) => {});
const onReverseChange = jest.fn((reverse: boolean) => {});
const onSkipChange = jest.fn((skip: SkipConfig) => {});
const onTransferChange = jest.fn((transfer: boolean) => {});
const onExileChange = jest.fn((exile: boolean) => {});
render(
<RoomSettingsModal
globalLogic={gl}
Expand All @@ -24,11 +28,15 @@ test("renders settings with given parameters", () => {
kakumei={kakumei}
reverse={reverse}
skip={skip}
transfer={transfer}
exile={exile}
onYagiriChange={onYagiriChange}
onJBackChange={onJBackChange}
onKakumeiChange={onKakumeiChange}
onReverseChange={onReverseChange}
onSkipChange={onSkipChange}
onTransferChange={onTransferChange}
onExileChange={onExileChange}
/>
);
const yagiriCb = screen.getByLabelText(/8切り/);
Expand All @@ -45,6 +53,10 @@ test("renders settings with given parameters", () => {
expect(skipOffRadio).toBeChecked();
expect(skipSingleRadio).not.toBeChecked();
expect(skipMultiRadio).not.toBeChecked();
const transferCb = screen.getByLabelText(/7渡し/);
expect(transferCb).not.toBeChecked();
const exileCb = screen.getByLabelText(/10捨て/);
expect(exileCb).not.toBeChecked();
});

test("can change settings", () => {
Expand All @@ -54,11 +66,15 @@ test("can change settings", () => {
const kakumei = true;
const reverse = false;
const skip = SkipConfig.OFF;
const transfer = false;
const exile = false;
const onYagiriChange = jest.fn((yagiri: boolean) => {});
const onJBackChange = jest.fn((jBack: boolean) => {});
const onKakumeiChange = jest.fn((kakumei: boolean) => {});
const onReverseChange = jest.fn((reverse: boolean) => {});
const onSkipChange = jest.fn((skip: SkipConfig) => {});
const onTransferChange = jest.fn((transfer: boolean) => {});
const onExileChange = jest.fn((exile: boolean) => {});
render(
<RoomSettingsModal
globalLogic={gl}
Expand All @@ -67,11 +83,15 @@ test("can change settings", () => {
kakumei={kakumei}
reverse={reverse}
skip={skip}
transfer={transfer}
exile={exile}
onYagiriChange={onYagiriChange}
onJBackChange={onJBackChange}
onKakumeiChange={onKakumeiChange}
onReverseChange={onReverseChange}
onSkipChange={onSkipChange}
onTransferChange={onTransferChange}
onExileChange={onExileChange}
/>
);
const yagiriCb = screen.getByLabelText(/8切り/);
Expand All @@ -93,4 +113,10 @@ test("can change settings", () => {
const skipMultiRadio = screen.getByLabelText(/マルチスキップ/);
fireEvent(skipMultiRadio, createClickEvent());
expect(onSkipChange).toHaveBeenCalledWith(SkipConfig.MULTI);
const transferCb = screen.getByLabelText(/7渡し/);
fireEvent(transferCb, createClickEvent());
expect(onTransferChange).toHaveBeenCalledWith(!transfer);
const exileCb = screen.getByLabelText(/10捨て/);
fireEvent(exileCb, createClickEvent());
expect(onExileChange).toHaveBeenCalledWith(!exile);
});
24 changes: 24 additions & 0 deletions src/components/roomSettingsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,15 @@ interface Props {
kakumei: boolean;
reverse: boolean;
skip: SkipConfig;
transfer: boolean;
exile: boolean;
onYagiriChange: (yagiri: boolean) => void;
onJBackChange: (jBack: boolean) => void;
onKakumeiChange: (kakumei: boolean) => void;
onReverseChange: (reverse: boolean) => void;
onSkipChange: (skip: SkipConfig) => void;
onTransferChange: (transfer: boolean) => void;
onExileChange: (exile: boolean) => void;
}

export default function RoomSettingsModal(props: Props) {
Expand Down Expand Up @@ -108,6 +112,26 @@ export default function RoomSettingsModal(props: Props) {
/>
</div>
</Form.Group>
<Form.Group className="mb-3" controlId="roomSettings_transfer">
<Form.Check
type="checkbox"
label={i18n.roomSettings_transfer()}
checked={props.transfer}
onChange={() => {
props.onTransferChange(!props.transfer);
}}
/>
</Form.Group>
<Form.Group className="mb-3" controlId="roomSettings_exile">
<Form.Check
type="checkbox"
label={i18n.roomSettings_exile()}
checked={props.exile}
onChange={() => {
props.onExileChange(!props.exile);
}}
/>
</Form.Group>
</Form>
</React.Fragment>
);
Expand Down
7 changes: 6 additions & 1 deletion src/i18n/interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
RuleConfig,
WebSocketErrorCode,
WaitReason,
YourTurnContext,
} from "dfg-messages";

export interface Result {
Expand Down Expand Up @@ -49,6 +50,8 @@ export interface I18nService {
roomSettings_skip_off: () => string;
roomSettings_skip_single: () => string;
roomSettings_skip_multiple: () => string;
roomSettings_transfer: () => string;
roomSettings_exile: () => string;
roomList_creator: () => string;
roomList_playerNameList: () => string;
roomList_state: () => string;
Expand Down Expand Up @@ -90,7 +93,7 @@ export interface I18nService {
game_passMessage: (playerName: string, remainingHandCount: number) => string;
game_initialInfo: (playerCount: number, deckCount: number) => string;
game_cardsProvided: (playerName: string, cardCount: number) => string;
game_yourTurn: () => string;
game_yourTurn: (context:YourTurnContext) => string;
game_turn: (playerName: string) => string;
game_discard: (
playerName: string,
Expand All @@ -102,6 +105,8 @@ export interface I18nService {
game_kakumei: () => string;
game_reversed: () => string;
game_skipped: (playerName: string) => string;
game_transferred: (fromPlayerName: string, toPlayerName: string, cardList: CardMessage[]) => string;
game_exiled: (playerName: string, cardList: CardMessage[]) => string;
game_ranked: (playerName: string, rankType: RankType) => string;
game_rankChanged: (
playerName: string,
Expand Down
Loading
Loading