Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assigned but unused variable warnings #502

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Fix assigned but unused variable warnings #502

merged 1 commit into from
Dec 27, 2022

Conversation

odlp
Copy link
Contributor

@odlp odlp commented Dec 20, 2022

Hello ,

Thanks for this gem, really useful!

I noticed when running an RSpec test suite (with warnings enabled) that requiring this gem generates some noise in the test output like:

$GEM_HOME/gems/pdf-reader-2.11.0/lib/pdf/reader/font.rb:85: warning: assigned but unused variable - y1
$GEM_HOME/gems/pdf-reader-2.11.0/lib/pdf/reader/font.rb:86: warning: assigned but unused variable - y2

A fairly minor annoyance, but when fixed the test suite in question has no further warnings; just a tranquil sea of green dots 😄

Requiring this gem, and running an RSpec test suite with warnings
enabled leads to noise in the test output like:

warning: assigned but unused variable - y1
warning: assigned but unused variable - y2
@yob yob merged commit f66a834 into yob:main Dec 27, 2022
@yob
Copy link
Owner

yob commented Dec 27, 2022

thanks!

@odlp odlp deleted the fix-warnings branch December 28, 2022 09:09
hidakatsuya added a commit to thinreports/thinreports-generator that referenced this pull request May 7, 2023
suppress warning: assigned but unused variable - y1
yob/pdf-reader#502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants