Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indent in readme #532

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix indent in readme #532

merged 1 commit into from
Feb 5, 2024

Conversation

cprodhomme
Copy link
Contributor

No description provided.

@sebbASF
Copy link
Contributor

sebbASF commented Feb 5, 2024

Are you sure the indents are not intentional?

@cprodhomme
Copy link
Contributor Author

Are you sure the indents are not intentional?

When you look at the readme, it's not seen to be intentional:

Capture d’écran 2024-02-05 à 18 44 23

@sebbASF
Copy link
Contributor

sebbASF commented Feb 5, 2024

The indent means the examples are much more obvious; there is better separation from the rest of the text.

But I did not write the page; I think we should leave it to the owner/author as to whether the indent is wanted.

yob
yob approved these changes Feb 5, 2024
View reviewed changes
Copy link
Owner

@yob yob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like it 👍

@yob yob merged commit 7b73e6c into yob:main Feb 5, 2024
@cprodhomme cprodhomme deleted the patch-1 branch February 7, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yob yob yob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cprodhomme @sebbASF @yob