Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct Error for try_* functions on Windows #38

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

nathaniel-daniel
Copy link
Contributor

Fixes #35. I also added a test to confirm the correct behavior, based on the example shown in the issue.

Copy link
Owner

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@yoshuawuyts yoshuawuyts merged commit 3213736 into yoshuawuyts:master Jan 23, 2023
@nathaniel-daniel
Copy link
Contributor Author

Thanks!

@nathaniel-daniel nathaniel-daniel deleted the windows-try-error branch January 24, 2023 02:42
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2023
bootstrap: replace `atty` with `is-terminal`, dedupe deps

`atty` reported as [unsound](https://rustsec.org/advisories/RUSTSEC-2021-0145), so replaced with `is-terminal`, also updated few crates to reduce dupes

fd-lock v3.0.8 -> v3.0.11 (yoshuawuyts/fd-lock@v3.0.8...v3.0.11, yoshuawuyts/fd-lock#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return proper Error for try_* on Windows
2 participants