Remove unsafe, alignment not guaranteed

yourbasic · May 9, 2017 · a6906f1 · a6906f1
1 parent 8cbd4b0
commit a6906f1
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/hash.go b/hash.go
@@ -1,7 +1,7 @@
 package bloom
 
 import (
-	"unsafe"
+	"encoding/binary"
 )
 
 // MurmurHash3 implementation adapted from Sébastien Paolacci
@@ -31,12 +31,9 @@ func (d *digest) bmix(p []byte) (tail []byte) {
 	h1, h2 := d.h1, d.h2
 	nblocks := len(p) / 16
 	for i := 0; i < nblocks; i++ {
-		t := (*[2]uint64)(unsafe.Pointer(&p[i*16]))
-		k1, k2 := t[0], t[1]
-		// Without unsafe:
-		// j := 16 * i
-		// k1 := binary.LittleEndian.Uint64(p[j : j+8])
-		// k2 := binary.LittleEndian.Uint64(p[j+8 : j+16])
+		j := 16 * i
+		k1 := binary.LittleEndian.Uint64(p[j : j+8])
+		k2 := binary.LittleEndian.Uint64(p[j+8 : j+16])
 		k1 *= c1
 		k1 = (k1 << 31) | (k1 >> 33)
 		k1 *= c2