Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Coupon): support for checkbox usage #12744

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Conversation

CatsAndMice
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 89.60%. Comparing base (f53e134) to head (36f61dd).
Report is 17 commits behind head on main.

Files Patch % Lines
packages/vant/src/coupon-list/CouponList.tsx 13.33% 11 Missing and 2 partials ⚠️
packages/vant/src/coupon-cell/CouponCell.tsx 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12744      +/-   ##
==========================================
- Coverage   89.81%   89.60%   -0.22%     
==========================================
  Files         257      257              
  Lines        6835     6876      +41     
  Branches     1660     1674      +14     
==========================================
+ Hits         6139     6161      +22     
- Misses        369      388      +19     
  Partials      327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenjiahan chenjiahan changed the title feat: 【Coupon】增加多选效果 feat(Coupon): support for checkbox usage Mar 31, 2024
@CatsAndMice
Copy link
Contributor Author

@chenjiahan 已对code review问题进行修改

@inottn
Copy link
Collaborator

inottn commented Mar 31, 2024

单选的交互并不完全适用于多选,可以适当优化下多选对应的 demo

@CatsAndMice
Copy link
Contributor Author

已优化多选对应的 demo,并且增加 list-button slot 用于开发者自定义底部提交按钮 @chenjiahan @inottn

@CatsAndMice
Copy link
Contributor Author

@chenjiahan 麻烦合并下这个PR

@chenjiahan
Copy link
Member

好的,明天处理下

@chenjiahan chenjiahan merged commit 3a524e8 into youzan:main Apr 6, 2024
3 checks passed
CatsAndMice added a commit to CatsAndMice/vant that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants