Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Coupon): simplify the checkbox usage #12771

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

chenjiahan
Copy link
Member

Simplify the checkbox usage and fix some mistakes.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 89.76%. Comparing base (3a524e8) to head (dda84bd).

Files Patch % Lines
packages/vant/src/coupon-list/CouponList.tsx 25.00% 5 Missing and 1 partial ⚠️
packages/vant/src/coupon-cell/CouponCell.tsx 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12771      +/-   ##
==========================================
+ Coverage   89.68%   89.76%   +0.07%     
==========================================
  Files         257      257              
  Lines        6884     6875       -9     
  Branches     1674     1672       -2     
==========================================
- Hits         6174     6171       -3     
+ Misses        382      376       -6     
  Partials      328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenjiahan chenjiahan merged commit fd89f71 into main Apr 6, 2024
7 checks passed
@chenjiahan chenjiahan deleted the coupon_checkbox_usage_0406 branch April 6, 2024 14:01
CatsAndMice pushed a commit to CatsAndMice/vant that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants