Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AricentISS firware 2.x #2866

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

davromaniak
Copy link
Contributor

@davromaniak davromaniak commented Jul 12, 2023

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • [ N/A ] Tests added or adapted (try rake test)
  • [ N/A ] Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Starting the 2.0 firmware, the pagination command has changed and the old one isn't supported (with or without the typo).

I tested it against switches running 2.1.3-25 and 2.2.1-38 without any issues.

Thanks.

@davromaniak
Copy link
Contributor Author

It should be cleaner now, again sorry for the multiple PRs.

Thanks.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (dab52d0) 66.55% compared to head (5117565) 66.55%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2866   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files          30       30           
  Lines        1507     1507           
=======================================
  Hits         1003     1003           
  Misses        504      504           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mortzu
Copy link
Collaborator

mortzu commented Jul 25, 2023

Can you please fix the conflict

@davromaniak
Copy link
Contributor Author

Hi.

I tried to fix the conflicts (without breaking everything this time...).

Can you check if it's OK ?

Thanks.

@mortzu mortzu merged commit 494d877 into ytti:master Aug 15, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants