Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dots & dashes in cumulus prompt username #2870

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Conversation

ktims
Copy link
Contributor

@ktims ktims commented Jul 14, 2023

Pre-Request Checklist

  • [*] Passes rubocop code analysis (try rubocop --auto-correct)
  • [-] Tests added or adapted (try rake test)
  • [-] Changes are reflected in the documentation
  • [-] User-visible changes appended to CHANGELOG.md

Description

Adjust prompt regex to behave correctly when the username portion includes a - or . which are valid characters in Linux usernames but not included in the \w regex shorthand.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.65% 🎉

Comparison is base (5075488) 65.90% compared to head (058d42b) 66.55%.

❗ Current head 058d42b differs from pull request most recent head ca70250. Consider uploading reports for the commit ca70250 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2870      +/-   ##
==========================================
+ Coverage   65.90%   66.55%   +0.65%     
==========================================
  Files          30       30              
  Lines        1525     1507      -18     
==========================================
- Hits         1005     1003       -2     
+ Misses        520      504      -16     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mortzu
Copy link
Collaborator

mortzu commented Jul 25, 2023

Please update CHANGELOG.md

@ktims
Copy link
Contributor Author

ktims commented Jul 28, 2023

@mortzu updated!

@mortzu mortzu merged commit a8b2b1f into ytti:master Jul 31, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants