-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for slackdiff. #3144
Fix for slackdiff. #3144
Conversation
I miss the update of the default timeout in the diff. Can you check that? |
Thanks for the comment. Changes from Master pulled and made changes to Changelog and actually changed the timeout. |
Something whent terribly wrong here, as many commits where integrated in this PR. Mabe a |
- Updated slackdiff.rb to use slack_ruby_client insteaf of slack-api.
4a82b3e
to
2b67223
Compare
Why should the default timeout be changed? If you don't like it, you can change it in your configuration. |
I've rebased your branch. Be sure to update your branch before submitting more commits. You may need a `git reset --hard. |
Thanks for fixing the branch. The timeout of 20 seconds is too few for devices with more complicated configurations, like firewalls, or some switches. It's also on the low-end when devices need to be pulled over higher latency. When setting up oxidized in our environment it was "broken" out of the box because of this. I figured this could help some first time users, but I can also leave it out and we'll just go with the slack fix. |
You can change the timeout in your configuration file:
I'll revert the timeout change an merge into master. |
Pre-Request Checklist
rubocop --auto-correct
)rake test
)Description
Fixes users experiencing the following error:
ERROR -- : Hook slack (#SlackDiff:0x00005572c9621e20) failed (#<NameError: uninitialized constant Slack::Client>) for event :post_store #2697