Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net/http/digest_auth to http input to prevent "uninitialized constant Net::HTTP::DigestAuth" #3232

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

spike77453
Copy link
Contributor

@spike77453 spike77453 commented Jul 19, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Using the http input with digest authentication causes the following error:

/usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/input/http.rb:63:in `get_http': uninitialized constant Net::HTTP::DigestAuth (NameError)
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/input/http.rb:44:in `cmd_str'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/input/http.rb:35:in `cmd'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/model/model.rb:122:in `cmd'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/model/model.rb:172:in `block in get'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/model/model.rb:171:in `each'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/model/model.rb:171:in `get'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/input/cli.rb:14:in `get'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/node.rb:70:in `run_input'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/node.rb:47:in `block in run'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/node.rb:41:in `each'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/node.rb:41:in `run'
        from /usr/local/share/gems/gems/oxidized-0.30.1/lib/oxidized/job.rb:10:in `block in initialize'

It seems this snuk in with this commit: e59b50f

This pull request adds the net-http-digest_auth gem as a runtime dependency and updates lib/oxidized/input/http.rb accordingly.

See also:

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.53%. Comparing base (6f515d5) to head (950d4e1).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3232   +/-   ##
=======================================
  Coverage   63.53%   63.53%           
=======================================
  Files          37       37           
  Lines        1862     1862           
=======================================
  Hits         1183     1183           
  Misses        679      679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertcheramy robertcheramy merged commit 9ef40fe into ytti:master Jul 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants