Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edgecos.rb #3248

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Update edgecos.rb #3248

merged 3 commits into from
Oct 2, 2024

Conversation

dhooper6430
Copy link
Contributor

Fix multiple temperature sensors reporting and multiple fan units reporting fan speeds that can be configured to be dynamic

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Fix multiple temperature sensors reporting and multiple fan units reporting fan speeds that can be configured to be dynamic
@dhooper6430
Copy link
Contributor Author

Output of 'show system' from a EdgeCore ECS5520-18X:

ECS5520-18X-CONSOLE#show system
System Description : ECS5520-18X
System OID String  : 1.3.6.1.4.1.259.10.1.51.102
System Information
 System Up Time         : 31 days, 14 hours, 9 minutes, and 19.90 seconds
 System Name            : ECS5520-18X
 System Location        : Some Location
 System Contact         :
 MAC Address (Unit 1)   : 00-00-00-00-00
 Web Server             : Enabled
 Web Server Port        : 80
 Web Secure Server      : Enabled
 Web Secure Server Port : 443
 Telnet Server          : Enabled
 Telnet Server Port     : 23
 Authentication Login   :  Local RADIUS None
 Authentication Enabled :  Local RADIUS None
 Jumbo Frame            : Enabled
 Large MMU              : Disabled

System Fan:
 Force Fan Speed Full   : Disabled
Unit 1
 Fan 1: Ok                    Fan 2: Ok                    Fan 3: Ok
 Fan 1 speed:  5572 rpm      Fan 2 speed:  5781 rpm      Fan 3 speed:  5869 rpm


System Temperature:
Unit 1
 Temperature 1:  34 degrees     Temperature 2:  26 degrees

Unit 1

 Main Power Status      : Up
 Redundant Power Status : Not present

@robertcheramy
Copy link
Collaborator

Thank you for your contribution.

  • Please provide a unit test for the model. You will need to rebase / merge from master in order to use model_helper.rb in the unit test.
  • Please document your changes in CHANGELOG.md

@robertcheramy
Copy link
Collaborator

Update - consider the unit test point as optional - making the yaml file is to complicated yet, I must improve the documentation before asking submitter do to so.
Please just document your changes in CHANGELOG.md

@robertcheramy robertcheramy merged commit d3fa27b into ytti:master Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants