Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated source files to avoid namespace duplication #3283

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

laf
Copy link
Contributor

@laf laf commented Oct 9, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

This possibly fixes issue #2154. I've got a limited test environment I've run this in and without changing the config file this works ok for me.

manager.rb may need more doing to it but this worked for me.

@laf
Copy link
Contributor Author

laf commented Oct 14, 2024

@robertcheramy Would you be able to review this change?

@robertcheramy
Copy link
Collaborator

Yes, I will look at your PR but must work on other issues and older PR first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants