optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

src/plugins/saved_objects_management/public/lib/duplicate_saved_objects.ts

@@ -1,12 +1,6 @@
 /*
+ * Copyright OpenSearch Contributors
  * SPDX-License-Identifier: Apache-2.0
- *
- * The OpenSearch Contributors require contributions made to
- * this file be licensed under the Apache-2.0 license or a
- * compatible open source license.
- *
- * Any modifications Copyright OpenSearch Contributors. See
- * GitHub history for details.
  */
 
 import { HttpStart } from 'src/core/public';

src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx

@@ -210,7 +210,7 @@ export class SavedObjectsDuplicateModal extends React.Component<Props, State> {
     if (duplicateMode === DuplicateMode.All) {
       selectedObjects = selectedObjects.filter((item) => this.isSavedObjectTypeIncluded(item.type));
     }
-    // If the target workspace is selected, all saved objects will be retained.
+    // If the target workspace is not selected, all saved objects will be retained.
     // If the target workspace has been selected, filter out the saved objects that belongs to the workspace.
     const includedSelectedObjects = selectedObjects.filter((item) =>
       !!targetWorkspaceId && !!item.workspaces ? !item.workspaces.includes(targetWorkspaceId) : true
@@ -285,7 +285,10 @@ export class SavedObjectsDuplicateModal extends React.Component<Props, State> {
           >
             <>
               <EuiText size="s" color="subdued">
-                {'Specify a workspace where the objects will be duplicated.'}
+                {i18n.translate(
+                  'savedObjectsManagement.objectsTable.duplicateModal.targetWorkspaceNotice',
+                  { defaultMessage: 'Specify a workspace where the objects will be duplicated.' }
+                )}
               </EuiText>
               <EuiSpacer size="s" />
               <EuiComboBox
@@ -312,9 +315,13 @@ export class SavedObjectsDuplicateModal extends React.Component<Props, State> {
           >
             <>
               <EuiText size="s" color="subdued">
-                {
-                  'We recommended duplicating related objects to ensure your duplicated objects will continue to function.'
-                }
+                {i18n.translate(
+                  'savedObjectsManagement.objectsTable.duplicateModal.relatedObjectsNotice',
+                  {
+                    defaultMessage:
+                      'We recommended duplicating related objects to ensure your duplicated objects will continue to function.',
+                  }
+                )}
               </EuiText>
               <EuiSpacer size="s" />
               <EuiCheckbox

src/plugins/saved_objects_management/public/management_section/objects_table/components/header.test.tsx

@@ -31,7 +31,6 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 import { Header } from './header';
-import { any } from 'bluebird';
 
 describe('Header', () => {
   it('should render normally', () => {

src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx

@@ -80,7 +80,7 @@ export interface TableProps {
   items: SavedObjectWithMetadata[];
   itemId: string | (() => string);
   totalItemCount: number;
-  onQueryChange: (query: any, filterFields?: string[]) => void;
+  onQueryChange: (query: any, filterFields: string[]) => void;
   onTableChange: (table: any) => void;
   isSearching: boolean;
   onShowRelationships: (object: SavedObjectWithMetadata) => void;

src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx

@@ -234,11 +234,6 @@ describe('SavedObjectsTable', () => {
     }));
   });
 
-  afterEach(() => {
-    jest.clearAllMocks();
-    jest.resetModules();
-  });
-
   it('should render normally', async () => {
     const component = shallowRender({ perPageConfig: 15 });
 

src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

@@ -95,8 +95,7 @@ import {
   SavedObjectsManagementNamespaceServiceStart,
 } from '../../services';
 import { Header, Table, Flyout, Relationships, SavedObjectsDuplicateModal } from './components';
-import { DataPublicPluginStart } from '../../../../data/public';
-
+import { DataPublicPluginStart } from '../../../../../plugins/data/public';
 import { DuplicateMode } from './';
 
 interface ExportAllOption {
@@ -657,7 +656,9 @@ export class SavedObjectsTable extends Component<SavedObjectsTableProps, SavedOb
       return null;
     }
     const { applications } = this.props;
-    const newIndexPatternUrl = applications.getUrlForApp('indexPatterns');
+    const newIndexPatternUrl = applications.getUrlForApp('management', {
+      path: 'opensearch-dashboards/indexPatterns',
+    });
 
     return (
       <Flyout