!Join fails validation because of missing colon in regex. Fixes aws#25

yyolk · Aug 13, 2017 · e1042a6 · e1042a6
1 parent c55d5d6
commit e1042a6
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/test/templates/output_section.yaml b/test/templates/output_section.yaml
@@ -0,0 +1,14 @@
+AWSTemplateFormatVersion: '2010-09-09'
+Transform: AWS::Serverless-2016-10-31
+Description: Simple CRUD webservice. State is stored in a SimpleTable (DynamoDB) resource.
+Resources:
+  MyApi:
+    Type: AWS::Serverless::Api
+    Properties:
+      DefinitionUri: s3://bucket/key
+      StageName: prod
+
+Outputs:
+  ApiUrl:
+    Description: URL of API endpoint
+    Value: !Join ['', ['https://', !Ref "MyApi", '.execute-api.', !Ref 'AWS::Region', '.amazonaws.com/Prod']]
diff --git a/validate_test.go b/validate_test.go
@@ -197,5 +197,24 @@ var _ = Describe("sam", func() {
 
 		})
 
+
+		Context("with non-resource sections in CloudFormation template", func() {
+
+			inputs := []string{
+				"test/templates/output_section.yaml",
+			}
+
+			for _, filename := range inputs {
+				Context("including "+filename, func() {
+					template, _, err := goformation.Open(filename)
+					It("should successfully validate the SAM template", func() {
+						Expect(err).To(BeNil())
+						Expect(template).ShouldNot(BeNil())
+					})
+				})
+			}
+
+		})
+
 	})
 })
diff --git a/vendor/github.com/awslabs/goformation/unmarshal.go b/vendor/github.com/awslabs/goformation/unmarshal.go