Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hints from configuration-metadata.json #1638

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

kasmarian
Copy link
Member

@kasmarian kasmarian commented Sep 25, 2023

Description

  • remove additional from the name of META-INF/additional-spring-configuration-metadata.json as it's the only metadata file of the project.
  • add groups to help IDEs identifying types of configuration

Motivation and Context

These changes should fix the issue where IDEs are unable to provide meaningful hints to uses about logbook configuration properties.

Addresses #1574

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

- remove `additional` from name
- add groups to help IDEs identifying types of configuration
@msdousti
Copy link
Collaborator

👍

@kasmarian kasmarian merged commit 08af0ae into main Sep 29, 2023
2 checks passed
@kasmarian kasmarian deleted the fix-spring-configuration-metadata branch September 29, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants