Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning about logbook.write.max-body-size not preventing the buffering #1777

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add a warning about logbook.write.max-body-size not preventing the buffering #1777

merged 1 commit into from
Mar 4, 2024

Conversation

kasmarian
Copy link
Member

@kasmarian kasmarian commented Mar 4, 2024 •
edited
Loading

Description

Add a warning about logbook.write.max-body-size not preventing the buffering

Motivation and Context

#1754

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@ado-dao
Copy link
Member

ado-dao commented Mar 4, 2024

👍

2 similar comments
@lukasniemeier-zalando
Copy link
Member

👍

@rishiraj88
Copy link

👍

@kasmarian kasmarian merged commit 417a5ba into main Mar 4, 2024
2 checks passed
@kasmarian kasmarian deleted the body-buffering branch March 4, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

@msdousti msdousti Awaiting requested review from msdousti msdousti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kasmarian @ado-dao @lukasniemeier-zalando @rishiraj88