(fix): handle streams in object mode while buffering (#258)

zalando · Sep 10, 2018 · b3d3b80 · b3d3b80
1 parent 6f7eb28
commit b3d3b80
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/streams/stringifier-stream.js b/lib/streams/stringifier-stream.js
@@ -83,7 +83,10 @@ module.exports = class StringifierStream extends stream.Transform {
             // Consume streams in parallel
             if (st instanceof stream) {
                 st.buffer = [];
-                const onData = data => st.buffer.push(data);
+                const onData = data => {
+                    data = data instanceof Buffer ? data : Buffer.from(data);
+                    st.buffer.push(data);
+                };
 
                 st.setMaxListeners(st.getMaxListeners() + 1);
                 st.on('data', onData);

diff --git a/tests/streams/stringifier-stream.js b/tests/streams/stringifier-stream.js
@@ -117,7 +117,7 @@ describe('Stringifier Stream', () => {
             let streams = [
                 new PassThrough(),
                 new PassThrough(),
-                new PassThrough()
+                new PassThrough({ objectMode: true })
             ];
             const stream = new StringifierStream(tag => {
                 if (tag && tag.name) {