Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add new types #92

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Feature/add new types #92

merged 9 commits into from
Mar 1, 2024

Conversation

immortal-tofu
Copy link
Contributor

@immortal-tofu immortal-tofu commented Feb 27, 2024 •
edited
Loading

jatZama
jatZama reviewed Feb 28, 2024
View reviewed changes
fhevm/params.go Outdated Show resolved Hide resolved
dartdart26
dartdart26 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Off-topic: looking at the amount of C and unsafe code we have, we need to think of ways to either reduce/eliminate it or have memory corruption/leak checks.

@immortal-tofu immortal-tofu merged commit 051d226 into main Mar 1, 2024
2 checks passed
@immortal-tofu immortal-tofu deleted the feature/add-new-types branch March 1, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatZama jatZama jatZama left review comments

@dartdart26 dartdart26 dartdart26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@immortal-tofu @dartdart26 @jatZama