Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzdb: Updating the raft lists #3672

Merged
merged 1 commit into from
Apr 20, 2022
Merged

fuzzdb: Updating the raft lists #3672

merged 1 commit into from
Apr 20, 2022

Conversation

kurobeats
Copy link
Contributor

Updating the raft lists as updates have been made by the SecLists project in the last few years

@kingthorin
Copy link
Member

kingthorin commented Mar 18, 2022

Note this is add-on is specifically based on fuzzDB. If lists are coming from other sources that might cause a sync/maintenance issues.

Assuming this goes ahead the DCO will need to be addressed and the CHANGELOG will need an entry.

@kurobeats
Copy link
Contributor Author

Note this is add-on is specifically based on fuzzDB. If lists are coming from other sources that might cause a sync/maintenance issues.

Assuming this goes ahead the DCO will need to be addressed and the CHANGELOG will need an entry.

I'm not overly worried about fuzzDB being the source, these particular files haven't been touched by that project in 7 years. On the DCO issue, can I fix that without trashing my existing merge? Happy to update the CHANGELOG, ideally what would you like to see added?

@thc202 thc202 changed the title Updating the raft lists fuzzdb: Updating the raft lists Mar 18, 2022
@thc202
Copy link
Member

thc202 commented Mar 18, 2022

Better to also PR the update in fuzzDB project.

@kingthorin
Copy link
Member

The DCO bit is simple:

git commit --amend --no-edit --signoff
git push --force

@kingthorin
Copy link
Member

For the CHANGELOG you can add to the unreleased change block, something like Updated RAFT lists based on more recent SecLists contributions.

@thc202
Copy link
Member

thc202 commented Apr 14, 2022

Could you fix up the commits?

@kingthorin
Copy link
Member

Just to keep everyone updated. I have been in-touch with the FuzzDB project owner. He needs to regain access to his GitHub account but is working on addressing the upstream PR and getting us access.

@kurobeats
Copy link
Contributor Author

Could you fix up the commits?

Apologies, what have I missed with the commit?

@kingthorin
Copy link
Member

Please do an interactive rebase and fix-up or squash into a single commit:

…ject in the last few years

Signed-off-by: Anthony Cozamanis <brick.and.blade@gmail.com>
@kurobeats
Copy link
Contributor Author

kurobeats commented Apr 20, 2022

Hopefully I've done it correctly.

@kingthorin
Copy link
Member

Looks like it 🙂

@thc202
Copy link
Member

thc202 commented Apr 20, 2022

Thank you!

@psiinon psiinon merged commit 02b00db into zaproxy:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants