Remove iframe scroll (deprecated) #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
|
Hi, Kindly take out time to test and merge this small improvement to HUD :) |
|
On my list! |
psiinon
approved these changes
Oct 20, 2023
|
This makes the bottom panel to have a scrollbar in macOS, while with attribute it didn't have it. (I don't mind much either way, since with the default settings it will not be shown unless scrolling in the frame.) |
So should we merge this as is? |
thc202
approved these changes
Oct 30, 2023
thc202
changed the title
|
Thank you!
That's fine by me but this will be checked further. |
|
I dont get the scrollbar on my mac - maybe its screensize dependant? |
psiinon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scroll attribute is deprecated on iframe; it is replaced with
overflow: hidden;CSS property.Reference: https://support.moonpoint.com/network/web/html/css/iframe-obsolete-elements.php