Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the legacy E2E tests and remove them from the critical path to cutting a release #162

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Fix the legacy E2E tests and remove them from the critical path to cutting a release #162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c6ea6e
Fix the legacy E2E tests and remove them from the critical path to cu…
RothAndrew Nov 9, 2021
45edc4c
Fix another spot in the pipeline that I missed
RothAndrew Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,12 @@ package:
paths:
- build/

# Don't run the legacy E2E tests on tags, since GitHub Actions is replacing them and they shouldn't be in the critical
# path to cutting a release.
e2e:
<<: *only-default
only:
- master
- merge_requests
stage: e2e
needs:
- job: package
Expand Down
5 changes: 4 additions & 1 deletion e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ testAPIEndpoints() {
loadZarfCA

# Test the docker registry
_curl "https://pipeline.zarf.dev/v2/"
# This is commented out because it already gets tested in the GitHub Actions pipeline. Without changes it fails
# due to the registry needing auth now, but it's already tested elsewhere so it doesn't need to be tested here.
# Eventually this whole file will be deleted when we have finished moving all of these tests over to GitHub Actions.
# _curl "https://pipeline.zarf.dev/v2/"

# Test gitea is up and can be logged into
_curl "https://zarf-git-user:${ZARF_PWD}@pipeline.zarf.dev/api/v1/user"
Expand Down