-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repository.go #2996
base: main
Are you sure you want to change the base?
Fix repository.go #2996
Conversation
fix: Clone of Azure devops git repo not working with private repositories Refs: zarf-dev#2994
✅ Deploy Preview for zarf-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting, I wonder if this is a regression from the error work that has been done or if this has always been here?
Not sure if this is easily testable but could be worth it to avoid regression.
src/internal/git/repository.go
Outdated
@@ -99,6 +99,8 @@ func Clone(ctx context.Context, rootPath, address string, shallow bool) (*Reposi | |||
err := r.gitCloneFallback(ctx, gitURLNoRef, ref, shallow) | |||
if err != nil { | |||
return nil, err | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else { | |
} | |
return r, nil |
Co-authored-by: Philip Laine <philip.laine@gmail.com>
fix: Clone of Azure devops git repo not working with private repositories
Refs: #2994
Description
Added return in case the Repository is correctly cloned by gitCloneFallback
Related Issue
Fixes #2994
Checklist before merging