refactor: skeleton creator #3042

phillebaba · 2024-09-27T10:00:42Z

Description

Refactors skeleton creator.

A major feature of the refactor is that the implementation no longer requires sitting in the correct directory to build.

This change also limits imports to a single level. This means that it is no longer possible to import n levels of local skeleton packages anymore.

Relates to #2969

netlify · 2024-09-27T10:01:01Z

Name	Link
🔨 Latest commit	`2ceb476`
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/670544833124bf0008a81825

codecov · 2024-09-27T10:03:01Z

Attention: Patch coverage is 34.79924% with 341 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/internal/packager2/layout/import.go	11.15%	220 Missing and 3 partials ⚠️
src/internal/packager2/layout/create.go	58.16%	57 Missing and 48 partials ⚠️
src/pkg/lint/schema.go	0.00%	11 Missing ⚠️
src/internal/packager2/layout/layout.go	77.77%	1 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
src/internal/packager2/layout/package.go	`49.41% <100.00%> (-1.15%)`	⬇️
src/pkg/packager/publish.go	`0.00% <ø> (ø)`
src/internal/packager2/layout/layout.go	`77.77% <77.77%> (ø)`
src/pkg/lint/schema.go	`57.14% <0.00%> (-16.55%)`	⬇️
src/internal/packager2/layout/create.go	`58.16% <58.16%> (ø)`
src/internal/packager2/layout/import.go	`11.15% <11.15%> (ø)`

src/internal/packager2/layout/create.go

schristoff · 2024-10-08T03:44:10Z

src/pkg/packager/publish.go

@@ -48,26 +50,36 @@ func (p *Packager) Publish(ctx context.Context) (err error) {
 	}

 	if p.cfg.CreateOpts.IsSkeleton {


Does this have to be changed?

No we can leave changing this until after publish has been refactored if you prefer.

I think that would be best

src/internal/packager2/layout/import.go

src/internal/packager2/layout/create.go

src/internal/packager2/layout/import.go

Signed-off-by: Philip Laine <philip.laine@gmail.com>

phillebaba requested review from a team as code owners September 27, 2024 10:00

phillebaba marked this pull request as draft September 27, 2024 10:06

phillebaba changed the title ~~refactor: creator~~ refactor: skeleton creator Sep 27, 2024

phillebaba force-pushed the refactor/creator branch 20 times, most recently from 8304cfd to e29a2ec Compare October 3, 2024 16:59

phillebaba force-pushed the refactor/creator branch 4 times, most recently from a86edd5 to 63c5a9f Compare October 7, 2024 13:56

phillebaba force-pushed the refactor/creator branch 6 times, most recently from 9b415b0 to 032ce43 Compare October 7, 2024 19:27

schristoff reviewed Oct 7, 2024

View reviewed changes