Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build options #34

Merged
merged 1 commit into from
Apr 18, 2024
Merged

add build options #34

merged 1 commit into from
Apr 18, 2024

Conversation

mopemope
Copy link
Contributor

Added optimal build options using cargo wizard.

@zbelial
Copy link
Owner

zbelial commented Apr 16, 2024

Hi @mopemope , thanks.
I have a question about panic = "abort" though, if we set this, I'm not sure whether a panic will make Emacs exit or not? If it will, we may lose the chance to see what causes panic, right?

@mopemope
Copy link
Contributor Author

Hi. @zbelial
Yes, you're right.
I'll fix that since it's set to abort for speed.

@zbelial zbelial merged commit 52e3aa5 into zbelial:master Apr 18, 2024
@zbelial
Copy link
Owner

zbelial commented Apr 18, 2024

Thanks.
I just merged. But I'm thinking about deleting the lld flag later for these reasons:

  1. Users have to install lld, and
  2. I read from somewhere that lld is not fully supported yet. Here is a issue from rust-lang.
  3. It just makes linking faster, so IMO it's not that important as the other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants