Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Transport route query not working in all cases (without stop area relation) #387

Closed
amenk opened this issue Jun 23, 2024 · 1 comment · Fixed by #388
Closed

Public Transport route query not working in all cases (without stop area relation) #387

amenk opened this issue Jun 23, 2024 · 1 comment · Fixed by #388

Comments

@amenk
Copy link
Contributor

amenk commented Jun 23, 2024

I stumbled across the public transport feature and it seems very cool :-)

AddisMapTransit recently did lots of Public Transport mapping in Addis Ababa, and the bus routes are not shown there for on OsmApp.

Example:

https://osmapp.org/node/11035607130#17.00/9.0107/38.7636

If I change the query to the simpler version

  const overpassQuery = `[out:csv(ref, colour; false; ';')];
  ${featureType}(${id});
    rel(bn)["route"~"bus|train|tram|subway|light_rail|ferry|monorail"];
    out;`;

it would work, as you can see in the following screenshot from localhost:

working route display

@Dlurak can you explain the query introduced here?
EDIT: actually you already did explain it in the PR - sorry for the noise.

Mapping Requirement:
It's important to note that for this enhancement to work, stops must be correctly mapped with the stop_area
relation. In cases where this mapping is not done accurately, the query will not find any routes at all.

So it might be a shortcoming in mapping in that area because the stop_area relation is not used.
I am not sure if this is a hard requirement in the public transport v2 mapping schema.

I also saw, that probably highway=bus_stop should be added to most of the stops, for rendering them on the map.

CC @alazar-tekle

@amenk amenk changed the title Public Transport route query not working in all cases Public Transport route query not working in all cases (without stop area relation) Jun 23, 2024
amenk added a commit to OpenPlaceGuide/osmapp that referenced this issue Jun 23, 2024
…area relations

* This tries to support nodes which are not contained in a stop_area relation but directly in a route relation, example: https://www.openstreetmap.org/node/11035607130 as of version 5
@kudlav
Copy link
Contributor

kudlav commented Jun 24, 2024

It could be a good fallback. If the stop is not part of the stop area relation, lines could be taken just from the stop point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants