Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highway labels styling #121

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Update highway labels styling #121

merged 1 commit into from
Jan 18, 2023

Conversation

Flohhhhh
Copy link
Contributor

Hello! This is my first contribution. My end-goal with osmapp is to use it at work. I am a public safety dispatcher, and I use Google Maps constantly for roadway geography.

I'm looking to help build osmapp to a place where it can replace Google Maps for my workflow so I added some key details that I use every day at work that were missing from osmapp previously.

Thanks! Let me know what you think 👍🏼

  • Added motorway junction labels
  • Adjusted spacing on labels slightly to compensate
  • Added oneway icons for highways at close zooms

Before:
image

After:
image

- Added motorway junction labels
- Adjusted spacing on labels slightly to compensate
- Added oneway icons for highways at close zooms
@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osmapp ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Jan 18, 2023 at 3:51PM (UTC)

@zbycz
Copy link
Owner

zbycz commented Jan 18, 2023

Hi @Flohhhhh, i love it. Great adjustments!
Myself i am not much advanced in the map styles, so i will be glad to expect more polish.

Also its good to hear, that you are finding osmap useful. What are the most missing features for you currently?

btw, how did you find that maptiler provides these data in the first place? And do you have any tool to work with it (like mapbox studio?) or do you do it trial&error right in osmapp?

@Flohhhhh
Copy link
Contributor Author

Flohhhhh commented Jan 18, 2023

@zbycz

The biggest thing missing unfortunately is Street View. Google has an exceptional street view setup.

However, with all of the details you can add in OSM, I may be able to live without it. What street view provides right now is basically just a crutch to fill in for everything else that is missing from Google's map, so hopefully with some diligent OSM work, I can get around that.

I used the MapTiler cloud editor. I found the matching preset and just used their JSON as a template.

@zbycz
Copy link
Owner

zbycz commented Jan 29, 2023

btw, what do you think of the Mapillary free street view? Does it cover your area? We currently take the featured photo from this service if there isnt any wikipedia link. But in some parts of the world it would show just empty space.

There is also KartaView project former OpenStreetView.

Both could be integrated in the App and i was already considering it, currently #90 in form of photos. And later perhaps by including their JS browser if possible (no issue yet).

@Flohhhhh
Copy link
Contributor Author

They both seem relatively good. Mapillary has higher quality images, but less images. KartaView seems to have more images but lower quality.

Obviously, neither of them reach the standard of Google's street view which is unfortunate.

@zbycz
Copy link
Owner

zbycz commented Jan 30, 2023

Yes, we will have to live with it, especially in opensource projects :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants