Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicStyle: Add house numbers #86

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Jan 16, 2022

This adds house numbers to the style.

@vercel
Copy link

vercel bot commented Jan 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/zbycz/osmapp/hbTgBQyBT1kTvUojWEuXqfDMZ1hK
✅ Preview: https://osmapp-git-fork-openplaceguide-feature-add-housenumbers-zbycz.vercel.app

@zbycz
Copy link
Owner

zbycz commented Jan 16, 2022

This works fine. Thanks for a great change!

Merging right now. 👍 👍

@zbycz zbycz merged commit 0df84af into zbycz:master Jan 16, 2022
@amenk
Copy link
Contributor Author

amenk commented Jan 16, 2022

@zbycz Thanks for your work and your quick review :-)

@zbycz
Copy link
Owner

zbycz commented Jan 16, 2022

I have to admit, if the submitted code needs some edits, it would usually take me much longer. This was just perfect :-)

Btw, are you planning to run custom openmaptiles instance? i was wondering what is your project OpenPlaceGuide. :)

@amenk
Copy link
Contributor Author

amenk commented Jan 16, 2022

Yes, we might run a custom OpenMapTiles instance - or just use MapTiler, not sure yet.
OpenPlaceGuide is the new working title for this https://github.com/openbusinessmap/openbusinessmap - which aims to reimplement what we did on AddisMap.com fully Open Source.

Even if I actually don't have much clue about React (yet), OsmApp is a strong candidate for the map-frontend.

@zbycz
Copy link
Owner

zbycz commented Jan 16, 2022

Very good. That sounds promissing, i would love to get more business info to OSM. Feel free to use anything you like.

I also recommend you to look at Makina maps, which is upgraded version of OTM with minutely updated data. I wanted to migrate osmapp to that, but the last time i checked, there was a live server only for Europe.

@amenk amenk deleted the feature/add-housenumbers branch January 22, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants