Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Amharic #89

Merged
merged 4 commits into from
Feb 5, 2022
Merged

Draft: Amharic #89

merged 4 commits into from
Feb 5, 2022

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Jan 17, 2022

Just a Stub to boot the review app :-)
Will be completed later.

@vercel
Copy link

vercel bot commented Jan 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/zbycz/osmapp/12Zbio5nTPVNv1sy8VRdVKjGHYMM
✅ Preview: https://osmapp-git-fork-openplaceguide-feature-amharic-zbycz.vercel.app

Updated the translation strings with Amharic v1.0 translations
@zbycz
Copy link
Owner

zbycz commented Jan 17, 2022

There should be "ready for review" button, please hit it once it is ready :)

@amenk
Copy link
Contributor Author

amenk commented Jan 19, 2022

yes, we still want to let some people proof-read it :-)

@amenk amenk marked this pull request as ready for review January 22, 2022 10:26
@amenk
Copy link
Contributor Author

amenk commented Feb 5, 2022

It is ready for review by the way :-)

@zbycz zbycz merged commit c555079 into zbycz:master Feb 5, 2022
@zbycz
Copy link
Owner

zbycz commented Feb 5, 2022

Thanks for the reminders. GIthub didnt notify me of the change, so comment is always better.

Thank you very much for delivering another translation 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants