Allow empty maps to merge function #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing empty maps to MapVal panics, so check and return MapValEmpty if we have an empty map to return
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 70.73% 70.74%
=======================================
Files 79 79
Lines 7176 7178 +2
=======================================
+ Hits 5076 5078 +2
Misses 1659 1659
Partials 441 441
Continue to review full report at Codecov.
|
|
Makes sense to me. Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing empty maps to MapVal panics. If we have an empty map after merging maps, return
MapValEmptyso that we avoid this panic. Fixes hashicorp/terraform#25303