Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version specific search keywords (python, ruby, java, qt) #604

Closed
azmodude opened this issue Sep 29, 2016 · 10 comments
Closed

Missing version specific search keywords (python, ruby, java, qt) #604

azmodude opened this issue Sep 29, 2016 · 10 comments

Comments

@azmodude
Copy link

Hi,

I have both the Python 2 and Python 3 docsets installed.
In zeal 0.2.x one could use the python 2: function and python 3: function prefixes/syntax to search in the respective docsets.
This seems to be no longer the case? python: function works just fine, the other return just nothing at all.

Thanks!

@trollixx
Copy link
Member

Zeal tries to use the same logic as Dash (details), and not use docset name as a prefix. Unfortunately, now now for Python 2/3 there's only python: prefix. Dash itself provides python2: and python3:, but I don't see where those are coming from. @Kapeli could you shed some light here?

@Kapeli
Copy link
Contributor

Kapeli commented Sep 30, 2016

In Dash those are hardcoded (because I was dumb back then).

The hardcoded cases are:

if([platform isEqualToString:@"python"])
{
    NSString *docsetName = docset[@"docsetName"];
    if([docsetName hasPrefix:@"Python 2"])
    {
        return @"python2:";
    }
    else if([docsetName hasPrefix:@"Python 3"])
    {
        return @"python3:";
    }
}
else if([platform isEqualToString:@"java"])
{
    NSString *docsetName = docset[@"docsetName"];
    if([docsetName isEqualToString:@"Java SE7"])
    {
        return @"java7:";
    }
    else if([docsetName isEqualToString:@"Java SE6"])
    {
        return @"java6:";
    }
    else if([docsetName isEqualToString:@"Java SE8"])
    {
        return @"java8:";
    }
}
else if([platform isEqualToString:@"qt"])
{
    NSString *docsetName = docset[@"docsetName"];
    if([docsetName hasPrefix:@"Qt 5"])
    {
        return @"qt5:";
    }
    else if([docsetName hasPrefix:@"Qt 4"])
    {
        return @"qt4:";
    }
    else if([docsetName isEqualToString:@"Qt"])
    {
        return @"qt4:";
    }
}
else if([platform isEqualToString:@"cocos2d"])
{
    NSString *docsetName = docset[@"docsetName"];
    if([docsetName hasPrefix:@"Cocos3D"])
    {
        return @"cocos3d:";
    }
}

@thorstenkampe
Copy link

I noticed this, too. python 2 and python 3 prefixes still worked with the CI build from September, 15th. So it must be very recent change.

@FichteFoll
Copy link

@thorstenkampe probably this one: 236eb00.

This is pretty crutial for docsets where different versions matter (Python for me).

@trollixx trollixx self-assigned this Oct 9, 2016
@trollixx trollixx modified the milestone: 0.3.1 Oct 9, 2016
@trollixx trollixx changed the title Searching with different Python prefixes/versions no longer works Missing version specific search keywords (python, ruby, java, qt) Nov 7, 2016
@FichteFoll
Copy link

FichteFoll commented Nov 10, 2016

I don't want to annoy, but could you perhaps raise priority for this issue? I need documentation on both Python 2 and 3 available but I get almost every entry twice now (when prefixing with python:).

@trollixx
Copy link
Member

trollixx commented Nov 10, 2016 via email

@trollixx trollixx added this to the 0.4.0 milestone Nov 16, 2016
@trollixx
Copy link
Member

The following keywords are now available:

Docset Keyword
Cocos3D cocos3d
Java SE6 java6
Java SE7 java7
Java SE8 java8
Python 2 python2
Python 3 python3
Qt 4 qt4
Qt 5 qt5
Ruby on Rails 3 ror3*
Ruby on Rails 4 ror4*
Ruby on Rails 5 ror5*

* Dash doesn't have version-specific keywords for the RoR docsets.

To make use of these keywords delete the affected docsets, update the docset list, and download the docsets back.

@azmodude
Copy link
Author

Thank you very much, I'll try a new version from git later tonight,

@FichteFoll
Copy link

Thank you, works like a charm!

@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

5 participants