Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter search by docstring #22

Merged
merged 1 commit into from
Aug 10, 2013

Conversation

christoffer
Copy link
Contributor

Adds a little syntax to allow filtering the search results to a specific (or a set of specific) docsets. This is a lightweight implementation of the similar feature in Dash.

The docset filter and the search query are delimited by a pipe character (|).

Examples:

  • ruby|set_x will search all docsets containing ruby (e.g. ironruby, ruby and ruby2) for set_x
  • set_x will search all docsets for set_x
  • ||set_x will search all docsets for |set_x.

jkozera added a commit that referenced this pull request Aug 10, 2013
Add ability to filter search by docstring
@jkozera jkozera merged commit 8f0fb1c into zealdocs:master Aug 10, 2013
@jkozera
Copy link
Member

jkozera commented Aug 10, 2013

Thanks! I just have one question about the ZealSearchQuery::ZealSearchQuery() constructor (with no arguments) - is there any use for it, or should I remove it?

@christoffer
Copy link
Contributor Author

Ah right, no drop it :) thanks

On Saturday, August 10, 2013, Jerzy Kozera notifications@github.com wrote:

Thanks! I just have one question about the
ZealSearchQuery::ZealSearchQuery() constructor (with no arguments) - is
there any use for it, or should I remove it?


Reply to this email directly or view it on GitHub.<
https://github.com/notifications/beacon/agC8Udkqju2CPJYAhRwX35HtOLduRSC0of0EsElPfOqp8rdoel3bhuDHa3NCdcNF.gif

Christoffer Klang
christoffer.klang@gmail.com
+49 1577 1985 855

Know Android? Know someone who does? Reply and let me know!

@Wattos
Copy link

Wattos commented Nov 7, 2013

@christoffer @jkozera I have tried using this feature (as the search results are too broad otherwise) but it simply does not seem to work. Is it possible that this feature does not work anymore?

I am currently using the Ubuntu ppa, but I have also tried compiling from source and it does not seem to work

EDIT: Nevermind, it seems the "|" changed to a ":" in the search string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants