Skip to content

Commit

Permalink
x86: vdso: Remove bogus locking in update_vsyscall_tz()
Browse files Browse the repository at this point in the history
Changing the sequence count in update_vsyscall_tz() is completely
pointless.

The vdso code copies the data unprotected. There is no point to change
this as sys_tz is nowhere protected at all. See sys_gettimeofday().

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
  • Loading branch information
KAGA-KOKO authored and johnstultz-work committed Mar 16, 2012
1 parent a4ca129 commit 6c260d5
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions arch/x86/kernel/vsyscall_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,7 @@ early_param("vsyscall", vsyscall_setup);

void update_vsyscall_tz(void)
{
unsigned long flags;

write_seqlock_irqsave(&vsyscall_gtod_data.lock, flags);
/* sys_tz has changed */
vsyscall_gtod_data.sys_tz = sys_tz;
write_sequnlock_irqrestore(&vsyscall_gtod_data.lock, flags);
}

void update_vsyscall(struct timespec *wall_time, struct timespec *wtm,
Expand Down

0 comments on commit 6c260d5

Please sign in to comment.