Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name collision #1029

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix name collision #1029

merged 1 commit into from
Jun 23, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Jun 22, 2023

What does it do?

Building the Zeitgeist runtime with srtool results in the following error:

error[E0423]: expected value, found struct variant call
--> /build/runtime/zeitgeist/src/lib.rs:130:15
|
130 | match call {
| ^^^^ you might want to surround a struct literal with parentheses: (call { /* fields */ })?

For more information about this error, try rustc --explain E0423.

The rust compiler used in the docker container is unable to distinguish call, which represents the RuntimeCall that is currently being process and call, which represents a dispatchable from pallet-contracts.

This PR assign unique names.

What important points should reviewers know?

None.

Is there something left for follow-up PRs?

No.

What alternative implementations were considered?

  • Renaming the contracts call variant.

Are there relevant PRs or issues?

No.

References

None.

@sea212 sea212 added the s:review-needed The pull request requires reviews label Jun 22, 2023
@sea212 sea212 added this to the v0.3.9 milestone Jun 22, 2023
@sea212 sea212 self-assigned this Jun 22, 2023
@sea212 sea212 changed the base branch from main to release-v0.3.9 June 22, 2023 22:07
@sea212 sea212 requested a review from Chralt98 June 22, 2023 22:07
@codecov-commenter
Copy link

Codecov Report

Merging #1029 (ee8f48d) into release-v0.3.9 (c347f33) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           release-v0.3.9    #1029   +/-   ##
===============================================
  Coverage           94.46%   94.46%           
===============================================
  Files                  93       93           
  Lines               21177    21177           
===============================================
  Hits                20004    20004           
  Misses               1173     1173           
Flag Coverage Δ
tests 94.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminds me of set_code

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jun 23, 2023
@sea212 sea212 merged commit 836be9e into release-v0.3.9 Jun 23, 2023
@sea212 sea212 deleted the sea212-fix-name-collision branch June 23, 2023 07:05
@sea212 sea212 mentioned this pull request Jul 3, 2023
sea212 added a commit that referenced this pull request Jul 5, 2023
* Update weights (#1025)

* Update crate and runtime version (#1026)

* Use argument in init.sh to avoid usage of sudo (#1028)

* Update scripts/init.sh

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Update script documentation

---------

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Fix name collision (#1029)

* Use updated Rococo bootnodes (#1030)

---------

Co-authored-by: Chralt <chralt.developer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants