Don't notify codeowners when only weight files or Cargo.toml are changed #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1478e10.
sea212
added
s:review-needed
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 94.49% 92.94% -1.56%
==========================================
Files 92 92
Lines 21072 21589 +517
==========================================
+ Hits 19913 20065 +152
- Misses 1159 1524 +365
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Chralt98
requested changes
Jul 21, 2023
Chralt98
reviewed
Jul 21, 2023
Co-authored-by: Chralt <chralt.developer@gmail.com>
sea212
added
s:in-progress
Co-authored-by: Chralt <chralt.developer@gmail.com>
sea212
added
s:review-needed
Chralt98
approved these changes
Jul 21, 2023
sea212
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Codeowners are not notified if only the weight files and/or Cargo.toml file are changed.
What important points should reviewers know?
The codeowners file is parsed backwards and stops on the first result. If a rule excludes codeowners (by not specifying any code owners after a path), the parsing stops for that file.
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References