Implement Hybrid AMM-CDA Router #1261
Conversation
| @@ -463,7 +464,10 @@ mod pallet { | |||
| ) -> DispatchResult { | |||
| let market = T::MarketCommons::market(&market_id)?; | |||
| ensure!(market.status == MarketStatus::Active, Error::<T>::MarketIsNotActive); | |||
| ensure!(market.scoring_rule == ScoringRule::Orderbook, Error::<T>::InvalidScoringRule); | |||
There was a problem hiding this comment.
Wouldn't ScoringRule::Orderbook still be valid?
There was a problem hiding this comment.
Good question. I just assumed because of Malte's proposal document that Orderbook scoring rule will be deleted. But now, when I consider your question, it makes total sense to allow users to use the order book scoring rule alone. However, every market will be initialized with ScoringRule::AmmCdaHybrid, that's why just using the order book pallet without using the HybridRouter will work.
There was a problem hiding this comment.
If every market is going to be initialised with ScoringRule::AmmCdaHybrid what will happen to parimutuel markets?
There was a problem hiding this comment.
From https://hackmd.io/NBVKUY1QT--YnotR5KUx2w#Scoring-Rules: "The Lmsr and Orderbook variants are removed from the ScoringRule enum and replaced by AmmCdaHybrid, which allows a market to use both the order book and the AMM."
If every market is going to be initialised with ScoringRule::AmmCdaHybrid what will happen to parimutuel markets?
The ScoringRule::Parimutuel object will not be deleted, so the parimutuel markets stay as they are.
Chralt98
added
s:abandoned
|
Abandoned in favor of multiple smaller PRs! |
What does it do?
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References