Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests for tag push #1320

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Conversation

Chralt98
Copy link
Member

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Apr 18, 2024
@Chralt98 Chralt98 self-assigned this Apr 18, 2024
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Apr 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (a77875d) to head (611bd2b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1320   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         202      202           
  Lines       38221    38221           
=======================================
  Hits        35301    35301           
  Misses       2920     2920           
Flag Coverage Δ
tests 92.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chralt98
Copy link
Member Author

I currently have no idea to move forward here https://github.com/zeitgeistpm/zeitgeist/actions/runs/8738968950/job/23982386333

And after using an extended timeout, I got another error Error: No response received from RPC endpoint in 60s here. So I changed the RPC endpoint to be dwellir instead of Zeitgeists..

I tried to execute the chopsticks integration tests in consecutive order, but no success. I tried to increase the timeout. I tried to understand the chopsticks logs. I verified the expected file structure. It may be an idea to update moonwall.

@Chralt98
Copy link
Member Author

I guess the endpoint of dwellir fixed the problem... /).- You can't understand how happy I am about finally fixing this..

@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Apr 19, 2024
@Chralt98 Chralt98 requested a review from sea212 April 19, 2024 11:09
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Apr 19, 2024
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Apr 19, 2024
@sea212
Copy link
Member

sea212 commented Apr 19, 2024

I guess the endpoint of dwellir fixed the problem... /).- You can't understand how happy I am about finally fixing this..

Perhaps some rate limiting issue. We might want to start to work with API keys.

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Apr 19, 2024
@mergify mergify bot merged commit 7000c0d into main Apr 19, 2024
47 checks passed
@mergify mergify bot deleted the chralt98-fix-integration-tests branch April 19, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants